[clr-ios] Run full test suite on Apple mobile platforms #123033

kotlarmilos · 2026-01-09T13:54:47Z

Description

This PR enables running full test suite on Apple mobile platforms.

Fixes #120055

dotnet-policy-service · 2026-01-09T16:09:27Z

Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

kotlarmilos · 2026-01-29T13:08:52Z

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

azure-pipelines · 2026-01-29T13:09:11Z

Azure Pipelines successfully started running 3 pipeline(s).

kotlarmilos · 2026-01-29T13:14:56Z

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

azure-pipelines · 2026-01-29T13:15:13Z

Azure Pipelines successfully started running 3 pipeline(s).

kotlarmilos · 2026-01-29T15:41:20Z

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

azure-pipelines · 2026-01-29T15:41:40Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

Enables broader (up to full) library/runtime test execution on Apple mobile platforms by adjusting Helix payload contents, Apple build MSBuild integration (CoreCLR + R2R/crossgen2), and CI pipeline configuration for iOS/tvOS/MacCatalyst.

Changes:

Add crossgen2 and related assets to Helix correlation payload and update Apple R2R compilation targets to reference local runtime-pack assemblies.
Expand Apple-mobile test project selection (libraries + functional tests) and propagate UseMonoRuntime into Helix build commands.
Update CI pipelines (timeouts, Helix arguments) to build/run broader test sets and optionally build Apple apps on Helix.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tests/Common/helixpublishwitharcade.proj	Ships additional CoreCLR build assets (crossgen2) when building Apple apps on Helix.
src/mono/msbuild/common/RuntimeComponentManifest.targets	Gates manifest-reading target to Mono runtime usage.
src/mono/msbuild/apple/build/AppleBuild.props	Makes Apple R2R targets import path robust (via `MSBuildThisFileDirectory`).
src/mono/msbuild/apple/build/AppleBuild.ReadyToRun.targets	Ensures crossgen2 gets full runtime-pack managed references (adds libs runtime files).
src/mono/msbuild/apple/build/AppleBuild.LocalBuild.props	Defines `Crossgen2InBuildDir` for AppleBuildSupportDir-based builds.
src/libraries/tests.proj	Expands Apple-mobile library/functional test inclusion and adjusts iossimulator conditions.
eng/testing/tests.targets	Disables runtime-async preview enabling on Android and Apple mobile targets.
eng/testing/tests.ioslike.targets	Passes `UseMonoRuntime` through Helix build command; always imports Apple build props.
eng/pipelines/runtime.yml	Updates Apple CoreCLR job build args/Helix behavior for broader library testing.
eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml	Extends timeouts and shifts MacCatalyst CoreCLR jobs to build/run more tests.
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslikesimulator.yml	Extends timeouts and enables “build apps on Helix” for iOS-like simulator runtime tests.
eng/pipelines/extra-platforms/runtime-extra-platforms-ioslike.yml	Extends timeouts and enables “build apps on Helix” for iOS/tvOS device runtime & library tests.

src/libraries/tests.proj

Copilot · 2026-01-30T08:15:19Z

eng/testing/tests.targets

    and '$(TargetOS)' != 'wasi'
+    and '$(TargetOS)' != 'android'
+    and '$(TargetsAppleMobile)' != 'true'
    and '$(RuntimeFlavor)' != 'Mono'
    and '$(UseRuntimeAsync)' != 'false'">


This block’s comment says runtime-async is enabled for “all .NET 11+ test projects”, but the condition now excludes Android and Apple mobile targets. Please update the comment to reflect these exclusions (or explain why these platforms are intentionally opted out).

kotlarmilos · 2026-01-30T08:39:18Z

/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst

azure-pipelines · 2026-01-30T08:39:35Z

Azure Pipelines successfully started running 3 pipeline(s).

kotlarmilos · 2026-01-30T14:04:07Z

/azp run runtime-ioslike

azure-pipelines · 2026-01-30T14:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Copilot · 2026-01-30T14:10:35Z

eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml

      nameSuffix: AllSubsets_CoreCLR_Smoke
-      buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:BuildTestsOnHelix=false /p:UseNativeAOTRuntime=false /p:RunSmokeTestsOnly=true
-      timeoutInMinutes: 120
+      buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false


In this MacCatalyst CoreCLR libraries job, the buildArgs no longer pass /p:BuildTestsOnHelix=true. For mobile targets (maccatalyst is TargetsMobile=true), ArchiveTests only runs when BuildTestsOnHelix=true (see eng/testing/tests.targets:92-95), so this job is likely to skip producing the test archives needed by the subsequent helix.yml step. Add /p:BuildTestsOnHelix=true to the buildArgs (or otherwise ensure BuildTestsOnHelix is set during the build) so archiving and Helix submission work consistently.

Suggested change

buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false

buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BuildTestsOnHelix=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false

Copilot · 2026-01-30T14:10:35Z

src/libraries/tests.proj

  <ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(TargetOS)' == 'ios' and '$(RunAOTCompilation)' == 'true'">
-    <!-- Only System.Runtime tests on iOS for now -->
+    <ProjectReference Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Runtime.Tests\System.Runtime.Tests.csproj" />
+
+    <ProjectReference Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Device\**\*.Test.csproj"
+                      Exclude="@(ProjectExclusions)"
+                      BuildInParallel="false" />
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(TargetOS)' == 'ios' and '$(RuntimeFlavor)' == 'CoreCLR' and '$(UseNativeAOTRuntime)' != 'true'">
    <ProjectReference Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Runtime.Tests\System.Runtime.Tests.csproj" />


These two ItemGroups add the same ProjectReference entries under overlapping conditions. If a CoreCLR iOS run is ever configured with RunAOTCompilation=true (or if RunAOTCompilation is set globally), the same projects will be referenced twice. Consider consolidating into a single ItemGroup with a mutually exclusive condition, or guard the first ItemGroup to exclude CoreCLR (e.g., add a RuntimeFlavor check) to avoid duplicate references and keep this section maintainable.

Run full test suite on Apple mobile platforms

4344f90

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 9, 2026

dotnet-policy-service bot assigned kotlarmilos Jan 9, 2026

lewing added the area-Infrastructure label Jan 9, 2026

github-project-automation bot added this to Runtime Infra Jan 9, 2026

lewing removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 9, 2026

Test run

17008b7

kotlarmilos added the os-ios Apple iOS label Jan 9, 2026

build-analysis bot mentioned this pull request Jan 9, 2026

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

Move AfterMicrosoftNETSdkTargets to tests.ioslike.targets

0d941eb

This was referenced Jan 13, 2026

Android System.Security.Cryptography test failure: Signing key verifies the CRL #119023

Open

CryptographicException in NonPowerOfTwoKeySizeOaepRoundtrip test #120606

Open

kotlarmilos added 3 commits January 14, 2026 15:47

Fix assemblies path for intree crossgen2

352054f

Revert changes

05157ad

Fix indentation in AppleBuild.props for clarity

6bfcef1

kotlarmilos added 2 commits January 16, 2026 14:22

Enable helix builds

2144772

Import crossgen2 from intree

f8bc27d

This was referenced Jan 16, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

browser-wasm linux LibraryTests build failure - NETSDK1022: Duplicate 'Content' items #123237

Closed

kotlarmilos added 2 commits January 26, 2026 17:31

Add condition to _MonoReadAvailableComponentsManifest target

903f537

Merge branch 'main' into improvement/clr-ios-full-tests-suite

f725ac8

build-analysis bot mentioned this pull request Jan 27, 2026

browser-wasm linux Release LibraryTests queues timing out #117974

Open

kotlarmilos added 2 commits January 29, 2026 10:56

Pass UseMonoRuntime property

126d31d

Add crossgen2 to the helix payload

1b6620e

Remove unused parameters

fd7161e

Merge branch 'main' into improvement/clr-ios-full-tests-suite

a74456e

Increase timeout and include libraries tests

cf08f82

Fix properties for tests

c87844b

Copilot AI review requested due to automatic review settings January 30, 2026 07:58

Copilot started reviewing on behalf of kotlarmilos January 30, 2026 07:59 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Revert changes

0e4bccc

Remove EnableAggressiveTrimming

26356ad

Copilot AI review requested due to automatic review settings January 30, 2026 13:56

Copilot started reviewing on behalf of kotlarmilos January 30, 2026 13:57 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

	buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false
	buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BuildTestsOnHelix=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false

[clr-ios] Run full test suite on Apple mobile platforms #123033

Are you sure you want to change the base?

[clr-ios] Run full test suite on Apple mobile platforms #123033

Uh oh!

Conversation

kotlarmilos commented Jan 9, 2026

Description

Uh oh!

dotnet-policy-service bot commented Jan 9, 2026

Uh oh!

kotlarmilos commented Jan 29, 2026

Uh oh!

azure-pipelines bot commented Jan 29, 2026

Uh oh!

kotlarmilos commented Jan 29, 2026

Uh oh!

azure-pipelines bot commented Jan 29, 2026

Uh oh!

kotlarmilos commented Jan 29, 2026

Uh oh!

azure-pipelines bot commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

kotlarmilos commented Jan 30, 2026

Uh oh!

azure-pipelines bot commented Jan 30, 2026

Uh oh!

kotlarmilos commented Jan 30, 2026

Uh oh!

azure-pipelines bot commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants